tlater/nix-flake-rework #2

Manually merged

tlater merged 5 commits from tlater/nix-flake-rework into master 2021-04-07 23:34:18 +01:00

Conversation 1 Commits 5 Files Changed 27

tlater commented 2021-04-07 23:32:40 +01:00

Owner

This is part of a bigger workflow to move the tlaternet server to flakes.

This portion is particularly tricky, since it involves converting this nodejs package. Previously, this was done through a tarball (I know... nodejs isn't easy to wrangle into a functional build).

This PR converts the previous approach into a proper build with the help of node2nix.

This also commits some yak-shaving, and upgrades to the newest version of the upstream parcel - might as well get all the annoying npm wrangling out of the way now.

Current patch works, but could use some cleaning. In a nutshell:

1. Introduction of nix flakes needs to be reworked.
   • Ideally this happens after all of the npm updates, since that way the node2nix generation only happens once and is a bit cleaner.
2. typescript/parcel update changes bleed into each other
   • Ideally we'd step through the update changes to make sure that we have all the fancy new packages and dependencies before starting to wade through typescript linitng.
3. Typescript formatting should be a separate commit
4. Make use of parcel validators (specifically typescript)
5. Updating npm dependencies is a chore
   • Not sure how to best do this, as npm doesn't seem to support udpating easily

This is part of a bigger workflow to move the tlaternet server to flakes. This portion is particularly tricky, since it involves converting this nodejs package. Previously, this was done through a tarball (I know... nodejs isn't easy to wrangle into a functional build). This PR converts the previous approach into a proper build with the help of [node2nix](https://github.com/svanderburg/node2nix). This also commits some yak-shaving, and upgrades to the newest version of the upstream parcel - might as well get all the annoying npm wrangling out of the way now. Current patch works, but could use some cleaning. In a nutshell: 1. [x] Introduction of nix flakes needs to be reworked. - Ideally this happens after all of the npm updates, since that way the `node2nix` generation only happens once and is a bit cleaner. 2. [x] typescript/parcel update changes bleed into each other - Ideally we'd step through the update changes to make sure that we have all the fancy new packages and dependencies *before* starting to wade through typescript linitng. 3. [x] Typescript formatting should be a separate commit 4. [ ] Make use of parcel validators (specifically typescript) 5. [x] Updating npm dependencies is a chore - Not sure how to best do this, as `npm` doesn't seem to support udpating easily

tlater added 5 commits 2021-04-07 23:32:40 +01:00

cb0f25e577

Update and fix dev-/dependency split

541c96806a

Introduce nix flake

de932501c5

Add typescript-eslint

7d028fdebd

Fix linting problems

144e52df2b

Fix indentation

tlater commented 2021-04-07 23:34:04 +01:00

Poster

Owner

Above points were fixed by:

1. Lots of rebasing
2. Realizing that parcel validators aren't quite mature

• Switched to eslint-typescript instead

3. Using npm-force-resolutions

Above points were fixed by: 1. Lots of rebasing 2. Realizing that parcel validators aren't quite mature - Switched to eslint-typescript instead 3. Using `npm-force-resolutions`

tlater manually merged commit 144e52df2b into master 2021-04-07 23:34:18 +01:00

tlater deleted branch tlater/nix-flake-rework 2021-04-07 23:34:26 +01:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tlaternet/tlaternet-templates#2

There is no content yet.