WIP: Rework the repository to work with nix flakes #1

Manually merged

tlater merged 0 commits from tlater/nix-flake-rework into master 2021-04-07 23:23:38 +01:00

Conversation 1 Commits - Files changed -

tlater commented 2021-04-06 23:40:19 +01:00

Owner

Copy link

This is part of a bigger workflow to move the tlaternet server to flakes.

This portion is particularly tricky, since it involves converting this nodejs package. Previously, this was done through a tarball (I know... nodejs isn't easy to wrangle into a functional build).

This PR converts the previous approach into a proper build with the help of node2nix.

This also commits some yak-shaving, and upgrades to the newest version of the upstream parcel - might as well get all the annoying npm wrangling out of the way now.

Current patch works, but could use some cleaning. In a nutshell:

1. Introduction of nix flakes needs to be reworked.
   • Ideally this happens after all of the npm updates, since that way the node2nix generation only happens once and is a bit cleaner.
2. typescript/parcel update changes bleed into each other
   • Ideally we'd step through the update changes to make sure that we have all the fancy new packages and dependencies before starting to wade through typescript linitng.
3. Typescript formatting should be a separate commit
4. Make use of parcel validators (specifically typescript)
5. Updating npm dependencies is a chore
   • Not sure how to best do this, as npm doesn't seem to support udpating easily

This is part of a bigger workflow to move the tlaternet server to flakes. This portion is particularly tricky, since it involves converting this nodejs package. Previously, this was done through a tarball (I know... nodejs isn't easy to wrangle into a functional build). This PR converts the previous approach into a proper build with the help of [node2nix](https://github.com/svanderburg/node2nix). This also commits some yak-shaving, and upgrades to the newest version of the upstream parcel - might as well get all the annoying npm wrangling out of the way now. Current patch works, but could use some cleaning. In a nutshell: 1. [x] Introduction of nix flakes needs to be reworked. - Ideally this happens after all of the npm updates, since that way the `node2nix` generation only happens once and is a bit cleaner. 2. [x] typescript/parcel update changes bleed into each other - Ideally we'd step through the update changes to make sure that we have all the fancy new packages and dependencies *before* starting to wade through typescript linitng. 3. [x] Typescript formatting should be a separate commit 4. [ ] Make use of parcel validators (specifically typescript) 5. [x] Updating npm dependencies is a chore - Not sure how to best do this, as `npm` doesn't seem to support udpating easily

tlater added 3 commits 2021-04-06 23:40:19 +01:00

WIP: Use nix flakes f81de40676

WIP: Adopt the new parcel beta release aefd2135f5

Fix typescript errors 9d968bc9ec

tlater force-pushed tlater/nix-flake-rework from 9d968bc9ec to 012b2954d0 2021-04-06 23:59:29 +01:00 Compare

tlater force-pushed tlater/nix-flake-rework from 012b2954d0 to 1160d96b06 2021-04-07 23:23:38 +01:00 Compare

tlater manually merged commit 1160d96b06 into master 2021-04-07 23:23:38 +01:00

tlater reopened this pull request 2021-04-07 23:30:24 +01:00

tlater commented 2021-04-07 23:31:51 +01:00

Author

Owner

Copy link

Well this PR broke...

Well this PR broke...

tlater closed this pull request 2021-04-07 23:32:01 +01:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tlaternet/tlaternet-templates#1

No description provided.