Fix use of global render/audio managers #7

New issue

Open

opened 2022-08-14 00:34:17 +01:00 by tlater · 0 comments

tlater commented

2022-08-14 00:34:17 +01:00

Owner

Currently, the music player and webgl renderers are implemented as global variables with a whole bunch of internal state.

They probably need to stay that way, but their interactions with react are unfortunate; specifically, react's useEffect is worked around a lot to get the visualizer to render, and at the same time some of redux' side-effect-freeness is violated in order to update the audio manager's source.

I need to find a better way of managing these.

Currently, the music player and webgl renderers are implemented as global variables with a whole bunch of internal state. They probably need to stay that way, but their interactions with react are unfortunate; specifically, react's `useEffect` is worked around *a lot* to get the visualizer to render, and at the same time some of redux' side-effect-freeness is violated in order to update the audio manager's source. I need to find a better way of managing these.