Clean up flash button logic a bit

This commit is contained in:
Tristan Daniël Maat 2022-08-13 20:58:33 +01:00
parent 0aa62525cb
commit 63f24aaedd
Signed by: tlater
GPG key ID: 49670FD774E43268

View file

@ -1,22 +1,16 @@
function registerFlashCloseButtons() {
const flashButtons = document.querySelectorAll(".notification .delete");
flashButtons.forEach((button) => {
const flash = button.parentNode;
if (flash === null) {
console.error(
"Unreachable because our `querySelector` includes a parent; something went very wrong"
);
return;
for (const flashButton of flashButtons) {
if (flashButton.parentNode === null) {
throw new Error("invalid flash button");
}
const flash = flashButton.parentNode;
flash.addEventListener("click", () => {
if (flash.parentNode === null) {
console.error(
"Notification not placed in DOM; something went very wrong"
);
return;
throw new Error("invalid flash message");
}
flash.parentNode.removeChild(flash);
@ -38,7 +32,7 @@ function registerFlashCloseButtons() {
const block = flash.parentNode;
flash.parentNode.parentNode.removeChild(block);
}
});
}
}
function registerNavCollapseButtons() {