tlaternet/tlaternet-templates
Archived
1
0
Fork 0
Code Issues 4 Pull requests Releases Wiki Activity

Hide flash messages during development

Browse source
This commit is contained in:
Tristan Daniël Maat 2022-08-06 19:34:28 +01:00
parent 594e9bcbfd
commit 02d0e5142b
Signed by: tlater
GPG key ID: 49670FD774E43268
2 changed files with 27 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/lib/html/message-flash.html
View file

@ -1,6 +1,8 @@
{{#if flash}} <span>
<div class="notification is-{{flash.type}}"> {{#if flash}}
<button class="delete" aria-label="Close"></button> <div class="notification is-{{flash.type}}">
<span role="alert"> {{ flash.message }} </span> <button class="delete" aria-label="Close"></button>
</div> <span role="alert"> {{ flash.message }} </span>
{{/if}} </div>
{{/if}}
</span>

26
src/lib/js/index.ts
View file

@ -4,7 +4,7 @@ document.addEventListener("DOMContentLoaded", () => {
flashButtons.forEach((button) => { flashButtons.forEach((button) => {
const flash = button.parentNode; const flash = button.parentNode;
if (flash == null) { if (flash === null) {
console.error( console.error(
"Unreachable because our `querySelector` includes a parent; something went very wrong" "Unreachable because our `querySelector` includes a parent; something went very wrong"
); );
@ -12,12 +12,7 @@ document.addEventListener("DOMContentLoaded", () => {
} }
flash.addEventListener("click", () => { flash.addEventListener("click", () => {
if (flash == null) { if (flash.parentNode === null) {
console.error("Completely unreachable.");
return;
}
if (flash.parentNode == null) {
console.error( console.error(
"Notification not placed in DOM; something went very wrong" "Notification not placed in DOM; something went very wrong"
); );
@ -26,6 +21,23 @@ document.addEventListener("DOMContentLoaded", () => {
flash.parentNode.removeChild(flash); flash.parentNode.removeChild(flash);
}); });
// In development, there won't be a web server hooked up to
// this to render the flash message, so we remove it entirely
if (process.env.NODE_ENV === "development") {
if (
flash.parentNode === null ||
flash.parentNode.parentNode === null
) {
return;
}
console.warn("Disabling flash message");
// Get the containing <span> element
const block = flash.parentNode;
flash.parentNode.parentNode.removeChild(block);
}
}); });
}); });